Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Twitch): Make patches compatible with latest versions #4099

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

oSumAtrIX
Copy link
Member

This fixes patching errors, however late versions of Twitch are only bundles and the last ones that are APK fail to compile due to resources being decoded incorrectly. Neither of which is matter for the patches though.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Dec 12, 2024 that may be closed by this pull request
3 tasks
@LisoUseInAIKyrios
Copy link
Contributor

Merge this before merging to main? The current twitch patches are effectively broken due to the app nagging to upgrade with no way to skip the nag.

@oSumAtrIX oSumAtrIX merged commit eecfbb7 into dev Dec 14, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 14, 2024
# [5.4.0-dev.11](v5.4.0-dev.10...v5.4.0-dev.11) (2024-12-14)

### Features

* **Twitch:** Make patches compatible with latest versions ([#4099](#4099)) ([eecfbb7](eecfbb7))
github-actions bot pushed a commit that referenced this pull request Dec 14, 2024
# [5.4.0](v5.3.0...v5.4.0) (2024-12-14)

### Bug Fixes

* **GmsCore support:** Adjust presentation of battery optimization dialog  ([#4091](#4091)) ([5d8fc1b](5d8fc1b))
* **TikTok - Settings:** Use correct colors for dark mode ([#4087](#4087)) ([6bd22ff](6bd22ff))
* **TikTok - SIM Spoof:** Change patch to default off to fix login ([#4084](#4084)) ([f4659a3](f4659a3))
* **YouTube - Hide ads:** Hide new type of featured promotions ([#4113](#4113)) ([13c7592](13c7592))
* **YouTube - Spoof video streams:** Fix error toast that is sometimes shown ([#4090](#4090)) ([4c46cb2](4c46cb2))
* **YouTube - Spoof video streams:** Resolve playback of age restricted videos ([#4096](#4096)) ([839a404](839a404))
* **YouTube Music - Bypass certificate checks:** Add a recommended target version ([#4104](#4104)) ([17a5a6c](17a5a6c))
* **YouTube Music - Spoof video streams:** Disable stable volume ([#4097](#4097)) ([16bb9df](16bb9df))

### Features

* Add Internal data documents provider patch ([#3830](#3830)) ([cb22f65](cb22f65))
* **Change package name:** Add options to change provider and permission package names to handle installation conflicts ([75c740c](75c740c))
* **Twitch:** Make patches compatible with latest versions ([#4099](#4099)) ([eecfbb7](eecfbb7))
* **YouTube - Comments:** Add `Hide 'Chat summary'` ([#4110](#4110)) ([269493c](269493c))
@Sbmhawk
Copy link

Sbmhawk commented Dec 14, 2024

What version of twitch should I be using now?

@LisoUseInAIKyrios
Copy link
Contributor

Latest release should work.

@sebm253
Copy link

sebm253 commented Dec 14, 2024

@LisoUseInAIKyrios the compatibility array here for Block video ads wasn't changed so it's still limited to <16.9.1, is it meant to be like that? https://github.com/ReVanced/revanced-patches/blob/ea90c57d23816006f53702b284fd264a0462cbc1/patches/src/main/kotlin/app/revanced/patches/twitch/ad/video/VideoAdsPatch.kt#L158-#L162

@oSumAtrIX
Copy link
Member Author

That should be removed

@LisoUseInAIKyrios LisoUseInAIKyrios deleted the feat/twitch-bump-versions branch December 14, 2024 20:15
@LisoUseInAIKyrios
Copy link
Contributor

Recommended version is fixed on dev. Turn off version check in Manager or use -f with CLI and it'll patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Twitch): v16.9.1 prompting to update
5 participants