Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viro 2.21.1 #56

Closed
Cchumi opened this issue Oct 12, 2021 · 10 comments
Closed

Viro 2.21.1 #56

Cchumi opened this issue Oct 12, 2021 · 10 comments
Assignees

Comments

@Cchumi
Copy link

Cchumi commented Oct 12, 2021

Hi it's not a pure issue but I investigate to find out why the 2.21.1 release is not working and show UIManager error for all the viro components.

I find the culprite..

I download the zip of 2.21.0 and 2.21.1 and find that for IOS libviroreact.a is not the good one.
The size of the package is not relevant for the lib.

image

If I check the same file on the 2.21.0 release this file is bigger

image

So I take all the libviroreact.a from 2.21.0 folder and paste it in my node module viro react.

I compile from xCode and now my app doesn't complain anymore for VRTText not found in UIManager.
And work as expected.

How can I build this libviroreact.a from my side ?

Hope this could give you the right way to fix that.

Cchumi

@ovy9086
Copy link

ovy9086 commented Nov 5, 2021

Downgrading to 2.20 solved this issue. so it seems something is wrong with 2.21 ? 🤔

@keithvongola
Copy link

Will there be a new release for the fix? 2.20 is not working on my android project

@doranteseduardo
Copy link
Member

Hello,
Yes, I have scheduled a release for this Nov 28 (Sunday)

@doranteseduardo
Copy link
Member

doranteseduardo commented Nov 23, 2021

Just to get you all in context.
The issue came into scene as we are unable to rebuild the static_lib variant of Viro.

Last time, when we made some changes to the iOS native side we were only able to build the library but the mentioned variant.

The static_lib has too many issues due the way the GVR was striped out.

So in the next release it will be removed, solving all this linking problems.

Edit:
If you use the another variant of the library (not the static_lib) it should work.

@Cchumi
Copy link
Author

Cchumi commented Nov 23, 2021

Great news @doranteseduardo you are welcome 🙏

I follow the submit for testing when it was released.

@doranteseduardo
Copy link
Member

The fix is ready, however I'd appreciate if you help testing out!
I'm about to upload an update and I need your help to test the iOS side just to be sure it's working as expected.

with this:
pod 'ViroKit', :path => '../node_modules/@viro-community/react-viro/ios/dist/ViroRenderer/'

  • Run "pod install" in the ios folder.

  • Run your app.

You should not have any issue on iOS anymore and also, ViroVideo must be working again.

I'd appreciate your feedback, if this test goes well it will be deployed into npm soon.

Thanks in advance!

@Cchumi
Copy link
Author

Cchumi commented Dec 6, 2021

Hi I just test it in my own app and it is working without any issue for the moment.

I just try also in starter kit and it is working as expected.

No more UIManager error.

Nice job :)

I will give a try on android in these days to see if it is also working.

@alencengic
Copy link

Hi @doranteseduardo I have also tested it and it works. Thank you! When it will be published?

@doranteseduardo
Copy link
Member

I'm working on some changes repository-level (due lfs) to publish this as soon as possible.

@doranteseduardo
Copy link
Member

doranteseduardo commented Dec 14, 2021

v2.22.0 is now in NPM and it fixes the iOS issues.
Thank you all for your time and support!

Note:
We have issues with the Github platform so the latest changes and the release may take few days to hit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants