Removed kinetic group additivity methods are still referenced in codebase #2605
Labels
bug
bug which will never be closed by the actions bot
Status: Discussion Needed
Discussion needed for further progress
Bug Description
A commit from last August (9f293be) removed various deprecated code, including functions in
rmgpy/data/kinetics/groups
andrmgpy/data/kinetics/family
related to computing rate coefficients using group additivity methods. Specifically, the method namedestimate_kinetics_using_group_additivity
in both of those files.However, references to these methods are still available in the codebase. For example, in
rmgpy/data/kinetics/family
:get_kinetics_for_template
includes the option to use group additivity methods. This template method is called inget_kinetics
and uses group additivity ifkinetics_estimator
is not provided, or ifgroup_additivity
is provided as the estimator.In
rmgpy/rmg/main.py
, the docstring mentions thatgroup_additivity
is a valid kinetic estimator method even though this does not seem to be the case anymore. Andrmgpy/rmg/model.py
considers the case ifkinetics_estimator
is group additivity.Expected Behavior
Code should run without calling a removed method that leads to an AttributeError.
Additional Context
We could either revert these changes, or we could commit to removing all references to group additivity. Previous discussion (see #975 (comment) and codebase pre-commit) indicated that group additivity should be deprecated for kinetics, however it has been available and a default method on the RMG Website. It might be helpful to figure out if the group additivity methods are so bad that we should just remove them altogether, or if they might be potentially useful for users on the website.
The text was updated successfully, but these errors were encountered: