fix(take): make 'take' unsubscribe when it reaches the total

ReactiveX · Mar 29, 2016 · 9858aa3 · 9858aa3
1 parent 5b8cb3e
commit 9858aa3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/spec/operators/take-spec.ts b/spec/operators/take-spec.ts
@@ -125,4 +125,14 @@ describe('Observable.prototype.take', () => {
     expectObservable(result, unsub).toBe(expected);
     expectSubscriptions(e1.subscriptions).toBe(e1subs);
   });
+
+  it('should unsubscribe from the source when it reaches the limit', () => {
+    const source = Observable.create(observer => {
+      expect(observer.isUnsubscribed).toBe(false);
+      observer.next(42);
+      expect(observer.isUnsubscribed).toBe(true);
+    }).take(1);
+
+    source.subscribe();
+  });
 });
diff --git a/src/operator/take.ts b/src/operator/take.ts
@@ -47,6 +47,7 @@ class TakeSubscriber<T> extends Subscriber<T> {
       this.destination.next(value);
       if (this.count === total) {
         this.destination.complete();
+        this.unsubscribe();
       }
     }
   }