Skip to content

Commit

Permalink
fix(micro-perf): rename immediate to queue scheduler
Browse files Browse the repository at this point in the history
Closes #1040.
  • Loading branch information
luisgabriel committed Dec 14, 2015
1 parent 43304a7 commit fe56b28
Show file tree
Hide file tree
Showing 34 changed files with 49 additions and 49 deletions.
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/observable/empty.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function empty(suite) {
var oldEmptyWithCurrentThreadScheduler = RxOld.Observable.empty(RxOld.Scheduler.currentThread);
var newEmptyWithCurrentThreadScheduler = RxNew.Observable.empty(RxNew.Scheduler.immediate);
var newEmptyWithCurrentThreadScheduler = RxNew.Observable.empty(RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ module.exports = function fromWithArray(suite) {
RxOld.Observable.from(args, null, null, RxOld.Scheduler.currentThread).subscribe(_next, _error, _complete);
})
.add('new from (array) with current thread scheduler', function () {
RxNew.Observable.from(args, null, null, RxNew.Scheduler.immediate).subscribe(_next, _error, _complete);
RxNew.Observable.from(args, null, null, RxNew.Scheduler.queue).subscribe(_next, _error, _complete);
});
};
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ module.exports = function fromWithString(suite) {
RxOld.Observable.from(argStr, null, null, RxOld.Scheduler.currentThread).subscribe(_next, _error, _complete);
})
.add('new from (string) with current thread scheduler', function () {
RxNew.Observable.from(argStr, null, null, RxNew.Scheduler.immediate).subscribe(_next, _error, _complete);
RxNew.Observable.from(argStr, null, null, RxNew.Scheduler.queue).subscribe(_next, _error, _complete);
});
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = function fromArray(suite) {
}

var oldFromArrayWithCurrentThreadScheduler = RxOld.Observable.fromArray(args, RxOld.Scheduler.currentThread);
var newFromArrayWithCurrentThreadScheduler = RxNew.Observable.fromArray(args, RxNew.Scheduler.immediate);
var newFromArrayWithCurrentThreadScheduler = RxNew.Observable.fromArray(args, RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/observable/interval.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function interval(suite) {
var oldIntervalWithCurrentThreadScheduler = RxOld.Observable.interval(25, RxOld.Scheduler.currentThread).take(5);
var newIntervalWithCurrentThreadScheduler = RxNew.Observable.interval(25, RxNew.Scheduler.immediate).take(5);
var newIntervalWithCurrentThreadScheduler = RxNew.Observable.interval(25, RxNew.Scheduler.queue).take(5);

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/observable/of.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = function of(suite) {
}

var oldOfWithCurrentThreadScheduler = RxOld.Observable.of.apply(null, args.concat(RxOld.Scheduler.currentThread));
var newOfWithCurrentThreadScheduler = RxNew.Observable.of.apply(null, args.concat(RxNew.Scheduler.immediate));
var newOfWithCurrentThreadScheduler = RxNew.Observable.of.apply(null, args.concat(RxNew.Scheduler.queue));

// add tests
function _next(x) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/observable/range.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = function range(suite) {
// add tests

var oldRangeWithCurrentThreadScheduler = RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread);
var newRangeWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate);
var newRangeWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/observable/throw.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function _throw(suite) {
var oldThrowWithCurrentThreadScheduler = RxOld.Observable.throw(new Error('error'), RxOld.Scheduler.currentThread);
var newThrowWithCurrentThreadScheduler = RxNew.Observable.throw(new Error('error'), RxNew.Scheduler.immediate);
var newThrowWithCurrentThreadScheduler = RxNew.Observable.throw(new Error('error'), RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/observable/timer.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function timer(suite) {
var oldTimerWithCurrentThreadScheduler = RxOld.Observable.timer(25, RxOld.Scheduler.currentThread).take(5);
var newTimerWithCurrentThreadScheduler = RxNew.Observable.timer(25, RxNew.Scheduler.immediate).take(5);
var newTimerWithCurrentThreadScheduler = RxNew.Observable.timer(25, RxNew.Scheduler.queue).take(5);

function _next(x) { }
function _error(e) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/catch.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldCatchWithCurrentThreadScheduler = RxOld.Observable.throw(new Error('error'), RxOld.Scheduler.currentThread)
.catch(function () { return RxOld.Observable.of(25, RxOld.Scheduler.currentThread); });
var newCatchWithCurrentThreadScheduler = RxNew.Observable.throw(new Error('error'), RxNew.Scheduler.immediate)
.catch(function () { return RxNew.Observable.of(25, RxNew.Scheduler.immediate); });
var newCatchWithCurrentThreadScheduler = RxNew.Observable.throw(new Error('error'), RxNew.Scheduler.queue)
.catch(function () { return RxNew.Observable.of(25, RxNew.Scheduler.queue); });

function _next(x) { }
function _error(e) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ module.exports = function (suite) {
add
);
var newCombineLatestWithCurrentThreadScheduler = RxNew.Observable.combineLatest(
RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate),
RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate),
RxNew.Observable.range(0, 25, RxNew.Scheduler.queue),
RxNew.Observable.range(0, 25, RxNew.Scheduler.queue),
add
);

Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/concat-many.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ module.exports = function (suite) {
.concatMap(function (x) {
return RxOld.Observable.range(x, 25, RxOld.Scheduler.currentThread);
});
var newConcatMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate)
var newConcatMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue)
.concatMap(function (x) {
return RxNew.Observable.range(x, 25, RxNew.Scheduler.immediate);
return RxNew.Observable.range(x, 25, RxNew.Scheduler.queue);
});

function _next(x) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/concatall.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ module.exports = function (suite) {
)
.concatAll();
var newConcatAllWithCurrentThreadScheduler = RxNew.Observable.fromArray(
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate); }),
RxNew.Scheduler.immediate
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.queue); }),
RxNew.Scheduler.queue
)
.concatAll();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function (suite) {
var oldDefaultIfEmptyWithCurrentThreadScheduler = RxOld.Observable.empty(RxOld.Scheduler.currentThread).defaultIfEmpty(25);
var newDefaultIfEmptyWithCurrentThreadScheduler = RxNew.Observable.empty(RxNew.Scheduler.immediate).defaultIfEmpty(25);
var newDefaultIfEmptyWithCurrentThreadScheduler = RxNew.Observable.empty(RxNew.Scheduler.queue).defaultIfEmpty(25);

function _next(x) { }
function _error(e) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/exhaust.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ module.exports = function (suite) {
)
.switchFirst();
var newMergeAllWithCurrentThreadScheduler = RxNew.Observable.fromArray(
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate); }),
RxNew.Scheduler.immediate
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.queue); }),
RxNew.Scheduler.queue
)
.exhaust();

Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/exhaustMap.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ module.exports = function (suite) {
.flatMapFirst(function (x) {
return RxOld.Observable.range(x, 25, RxOld.Scheduler.currentThread);
});
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate)
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue)
.exhaustMap(function (x) {
return RxNew.Observable.range(x, 25, RxNew.Scheduler.immediate);
return RxNew.Observable.range(x, 25, RxNew.Scheduler.queue);
});

function _next(x) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = function (suite) {

var oldFilterWithCurrentThreadScheduler = RxOld.Observable.range(0, 50, RxOld.Scheduler.currentThread)
.filter(divByTwo).filter(divByTen);
var newFilterWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.immediate)
var newFilterWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.queue)
.filter(divByTwo).filter(divByTen);

function _next(x) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/groupby.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = function (suite) {

var oldGroupByWithCurrentThreadScheduler = RxOld.Observable.fromArray(source, RxOld.Scheduler.currentThread)
.groupBy(group);
var newGroupByWithCurrentThreadScheduler = RxNew.Observable.fromArray(source, RxNew.Scheduler.immediate)
var newGroupByWithCurrentThreadScheduler = RxNew.Observable.fromArray(source, RxNew.Scheduler.queue)
.groupBy(group);

function _next(x) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function (suite) {
var oldIgnoreElementsWithCurrentThreadScheduler = RxOld.Observable.range(0, 50, RxOld.Scheduler.currentThread).ignoreElements();
var newIgnoreElementsWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.immediate).ignoreElements();
var newIgnoreElementsWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.queue).ignoreElements();

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/map.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function (suite) {
return x + x;
}
var oldSelectWithCurrentThreadScheduler = RxOld.Observable.range(0, 50).map(square).map(double);
var newSelectWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.immediate).map(square).map(double);
var newSelectWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.queue).map(square).map(double);

function _next(x) { }
function _error(e) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/merge.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldMergeWithCurrentThreadScheduler = RxOld.Observable.range(0, 250, RxOld.Scheduler.currentThread)
.merge(RxOld.Observable.range(0, 250, RxOld.Scheduler.currentThread));
var newMergeWithCurrentThreadScheduler = RxNew.Observable.range(0, 250, RxNew.Scheduler.immediate)
.merge(RxNew.Observable.range(0, 250, RxNew.Scheduler.immediate));
var newMergeWithCurrentThreadScheduler = RxNew.Observable.range(0, 250, RxNew.Scheduler.queue)
.merge(RxNew.Observable.range(0, 250, RxNew.Scheduler.queue));

function _next(x) { }
function _error(e) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/mergeall.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ module.exports = function (suite) {
)
.mergeAll();
var newMergeAllWithCurrentThreadScheduler = RxNew.Observable.fromArray(
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate); }),
RxNew.Scheduler.immediate
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.queue); }),
RxNew.Scheduler.queue
)
.mergeAll();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldMergeMapWithCurrentThreadScheduler = RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread)
.flatMap(RxOld.Observable.return(0, RxOld.Scheduler.currentThread));
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate)
.mergeMapTo(RxNew.Observable.of(0, RxNew.Scheduler.immediate));
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue)
.mergeMapTo(RxNew.Observable.of(0, RxNew.Scheduler.queue));

function _next(x) { }
function _error(e) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldMergeMapWithCurrentThreadScheduler = RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread)
.flatMap(RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread));
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate)
.mergeMapTo(RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate));
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue)
.mergeMapTo(RxNew.Observable.range(0, 25, RxNew.Scheduler.queue));

function _next(x) { }
function _error(e) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = function (suite) {
.flatMap(function (x) {
return RxOld.Observable.return(x, RxOld.Scheduler.currentThread);
});
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate)
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue)
.mergeMap(function (x) {
return RxNew.Observable.of(x);
});
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/mergemap.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ module.exports = function (suite) {
.flatMap(function (x) {
return RxOld.Observable.range(x, 25, RxOld.Scheduler.currentThread);
});
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate)
var newMergeMapWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue)
.mergeMap(function (x) {
return RxNew.Observable.range(x, 25, RxNew.Scheduler.immediate);
return RxNew.Observable.range(x, 25, RxNew.Scheduler.queue);
});

function _next(x) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/reduce.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = function (suite) {
return x + x;
}
var oldReduceWithCurrentThreadScheduler = RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread).reduce(add);
var newReduceWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate).reduce(add);
var newReduceWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue).reduce(add);

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/skip.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function (suite) {
var oldSkipWithCurrentThreadScheduler = RxOld.Observable.range(0, 50, RxOld.Scheduler.currentThread).skip(25);
var newSkipWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.immediate).skip(25);
var newSkipWithCurrentThreadScheduler = RxNew.Observable.range(0, 50, RxNew.Scheduler.queue).skip(25);

function _next(x) { }
function _error(e) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldStartWithWithCurrentThreadScheduler = RxOld.Observable.of(25, RxOld.Scheduler.currentThread)
.startWith(RxOld.Scheduler.currentThread, 5, 5, 5);
var newStartWithWithCurrentThreadScheduler = RxNew.Observable.of(25, RxNew.Scheduler.immediate)
.startWith(5, 5, 5, RxNew.Scheduler.immediate);
var newStartWithWithCurrentThreadScheduler = RxNew.Observable.of(25, RxNew.Scheduler.queue)
.startWith(5, 5, 5, RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldStartWithWithCurrentThreadScheduler = RxOld.Observable.of(25, RxOld.Scheduler.currentThread)
.startWith(RxOld.Scheduler.currentThread, 5);
var newStartWithWithCurrentThreadScheduler = RxNew.Observable.of(25, RxNew.Scheduler.immediate)
.startWith(5, RxNew.Scheduler.immediate);
var newStartWithWithCurrentThreadScheduler = RxNew.Observable.of(25, RxNew.Scheduler.queue)
.startWith(5, RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/switch.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ module.exports = function (suite) {
)
.switch();
var newSwitchWithCurrentThreadScheduler = RxNew.Observable.fromArray(
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate); }),
RxNew.Scheduler.immediate
source.map(function () { return RxNew.Observable.range(0, 25, RxNew.Scheduler.queue); }),
RxNew.Scheduler.queue
)
.switch();

Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/take.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function (suite) {
var oldTakeWithCurrentThreadScheduler = RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread).take(5);
var newTakeWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate).take(5);
var newTakeWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue).take(5);

function _next(x) { }
function _error(e) { }
Expand Down
4 changes: 2 additions & 2 deletions perf/micro/current-thread-scheduler/operators/timeinterval.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ var RxNew = require('../../../../index');
module.exports = function (suite) {
var oldTimeIntervalWithCurrentThreadScheduler = RxOld.Observable.interval(25, RxOld.Scheduler.currentThread)
.take(5).timeInterval(RxOld.Scheduler.currentThread);
var newTimeIntervalWithCurrentThreadScheduler = RxNew.Observable.interval(25, RxNew.Scheduler.immediate)
.take(5).timeInterval(RxNew.Scheduler.immediate);
var newTimeIntervalWithCurrentThreadScheduler = RxNew.Observable.interval(25, RxNew.Scheduler.queue)
.take(5).timeInterval(RxNew.Scheduler.queue);

function _next(x) { }
function _error(e) { }
Expand Down
2 changes: 1 addition & 1 deletion perf/micro/current-thread-scheduler/operators/toarray.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var RxNew = require('../../../../index');

module.exports = function (suite) {
var oldToArrayWithCurrentThreadScheduler = RxOld.Observable.range(0, 25, RxOld.Scheduler.currentThread).toArray();
var newToArrayWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.immediate).toArray();
var newToArrayWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue).toArray();

function _next(x) { }
function _error(e) { }
Expand Down

0 comments on commit fe56b28

Please sign in to comment.