Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix javadoc wording of {Publish|Behavior}Processor::offer() #7328

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

akarnokd
Copy link
Member

The Javadoc of BehaviorProcessor::offer still mentioned PublishProcessor. Also calling with null would throw an NPE and no longer error the subscribers.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #7328 (d78fc22) into 3.x (939b5ce) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7328      +/-   ##
============================================
- Coverage     99.57%   99.53%   -0.05%     
+ Complexity     6783     6779       -4     
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47281    47260      -21     
- Misses           92       99       +7     
- Partials        109      123      +14     
Impacted Files Coverage Δ
...eactivex/rxjava3/processors/BehaviorProcessor.java 100.00% <ø> (ø)
...reactivex/rxjava3/processors/PublishProcessor.java 100.00% <ø> (ø)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 91.74% <0.00%> (-6.43%) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0.00%> (-4.66%) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-3.97%) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0.00%> (-3.97%) ⬇️
...internal/operators/completable/CompletableAmb.java 96.72% <0.00%> (-3.28%) ⬇️
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 91.54% <0.00%> (-2.12%) ⬇️
...ators/observable/ObservableFlatMapCompletable.java 98.52% <0.00%> (-1.48%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939b5ce...d78fc22. Read the comment docs.

@akarnokd akarnokd merged commit b476914 into ReactiveX:3.x Aug 30, 2021
@akarnokd akarnokd deleted the JavadocFix0830 branch August 30, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants