-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @NonNull annotations for functions with void return type #7425
Merged
akarnokd
merged 1 commit into
ReactiveX:3.x
from
pahakorolev:3.x-remove-nonnull-from-void-function
May 27, 2022
Merged
Remove @NonNull annotations for functions with void return type #7425
akarnokd
merged 1 commit into
ReactiveX:3.x
from
pahakorolev:3.x-remove-nonnull-from-void-function
May 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #7425 +/- ##
============================================
- Coverage 99.55% 99.55% -0.01%
Complexity 6781 6781
============================================
Files 751 751
Lines 47482 47482
Branches 6378 6378
============================================
- Hits 47272 47271 -1
- Misses 92 96 +4
+ Partials 118 115 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This was referenced Jun 1, 2022
1 task
This was referenced Jun 17, 2022
Open
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Open
1 task
1 task
1 task
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor code readability improvement, which does not make you wonder on @nonnull void type.