Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setExact rather than set #10

Closed
Red-Folder opened this issue Feb 19, 2014 · 2 comments
Closed

Use setExact rather than set #10

Red-Folder opened this issue Feb 19, 2014 · 2 comments
Labels
enhancement

Comments

@Red-Folder
Copy link
Owner

Luigi raised concern over the accuracy. Asked to change:

am.set(AlarmManager.RTC_WAKEUP, when.getTime(), pi);
to become
am.setExact(AlarmManager.RTC_WAKEUP, when.getTime(), pi);

Need to just validate that this isn't going to cause any other issue. Might want to provide the ability for the developer to specify exact or not.
@Red-Folder
Copy link
Owner Author

Add logic to check if API 19+. If not, then use set rather than setExact

@Red-Folder Red-Folder added this to the End of February 2014 milestone Feb 19, 2014
@Red-Folder Red-Folder removed this from the End of February 2014 milestone Mar 3, 2014
Red-Folder referenced this issue in luigi37/Scheduler-Plugin Mar 8, 2014
@luigi37
Update SchedulerPlugin.java
9f81d63 
Since, from API level 19, alarm.set is not any longer fixed in time but is approximate and decided by Android, we use alarm.setExact for >=19 (kitkat)

Note: it seems to be working but not testing completely...
@Red-Folder Red-Folder mentioned this issue Mar 8, 2014
Merged
@Red-Folder
Copy link
Owner Author

Done by Luigi under commit 53a72aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Red-Folder