Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A parameter for specifying a particular script file for execuation #122

Open
bhanurz opened this issue May 9, 2022 · 4 comments
Open

A parameter for specifying a particular script file for execuation #122

bhanurz opened this issue May 9, 2022 · 4 comments

Comments

@bhanurz
Copy link

bhanurz commented May 9, 2022

Is your feature request related to a problem? Please describe.
We use gradle-confluent for in our CI/CD. We often come across scenarios where we want to execute a single file rather than all files under a directory.

Describe the solution you'd like
If there was a pipeline-file parameter to specify a particular file in the pipeline directory, then it would allow us specify required file.
Example:

gradle pipelineExecute --pipeline-dir /path/to/pipeline --pipeline-file pipeline-file.sql

This would read following file for execution:

/path/to/pipeline/pipeline-file.sql

Note that adding new param is backward compatible.

Describe alternatives you've considered
Alternative solution was to put every file in a directory so we can specify the wrapper directory if we wanted to execute a single file. This was not a clean solution so we did not go ahead with this.

Additional context
Proposed changes:
#121

@bhanurz
Copy link
Author

bhanurz commented May 9, 2022

@stewartbryson Hello, please check the above feature request and attached PR for proposed changes. Thank you.

@stewartbryson
Copy link
Member

I've been traveling the last 2 weeks... sorry for the delay.

I'm curious... have you tested passing the full path to the file to --pipeline-dir? I believe that actually works. If so, perhaps just a rename of --pipeline-dir would be the better choice here. Just trying to simplify. It's a breaking change, so maybe that is something to consider as well.

@bhanurz
Copy link
Author

bhanurz commented Jun 27, 2022

@stewartbryson Hello. We tried with pipeline-dir but it does not work and returns an error that reports that a directory path is expected.
Also note that it is not a breaking change as we are not changing the behaviour of existing options rather we are adding a new option that let's us point to a specific file relative to pipeline-dir.

@stewartbryson
Copy link
Member

PR is merged. Please test and close this issue if it’s working. Thanks a bunch for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants