Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a /test task #71

Open
Sikta opened this issue Sep 10, 2019 · 2 comments
Open

Support a /test task #71

Sikta opened this issue Sep 10, 2019 · 2 comments

Comments

@Sikta
Copy link

Sikta commented Sep 10, 2019

Is your feature request related to a problem? Please describe.
Our deployment process expects e2e tests with a rollback if they fail. That would be very difficult to do with KSQL.

Describe the solution you'd like
Add an opinionated /test task using https://github.com/confluentinc/ksql/blob/master/docs/developer-guide/ksql-testing-tool.rst. Requires setting up a test folder with input files structured the same as the sql files in the src folder. Use the next input as the output in the ksql-test-runner command. And require an extra ending file for the last test.

Additional context
If we added support for this, we could run the /test task in our jenkins PR & CD build and feel more comfortable that the updates are tested before deploying.

@Sikta
Copy link
Author

Sikta commented Sep 10, 2019

@stewartbryson what do you think about something like this?

@stewartbryson
Copy link
Member

The plugin already creates the ksql-script.sql file which could be the input to the ksql-test-runner. I supposed the input JSON file would simply need to be checked in with a known, configurable location. We could either rely on an already installed ksql-test-runner, or install it automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants