Merge pull request #9 from RegioneER/app_config

Config app by environment variables

.gitignore

@@ -9,7 +9,6 @@
 bin/
 buildout-cache/
 buildout.cfg
-config.py
 develop-eggs/
 eggs/
 etc/

README.rst

@@ -61,18 +61,17 @@ And it will start and manage all services.
 Custom configurations
 ---------------------
 
-You can add a ``config.py`` file in the root of the application to add custom configuration for Flask app.
+You can add a custom configuration for Flask app by adding the environments variables
 
-For example if you want to addcustomize Flask-Mail mail server address (default is localhost), you can create a file like this::
+For example if you want to customize Flask-Mail mail server address (default is localhost), you can create this environment variable::
 
-    Class Config(object):
-        MAIL_SERVER = 'my.custom.server'
+   export RER_NEWSLETTERDISPATCHER_MAIL_SERVER="myserver.net"
 
 You can set base Flask config parameters and some application-related ones:
 
-- MAIL_SERVER (mailserver address)
-- SENTRY_DSN (sentry dsn value)
-- REDIS_PORT (port where redis should listen. Default is 6379 but it's better to change it)
+- RER_NEWSLETTERDISPATCHER_MAIL_SERVER (mailserver address)
+- RER_NEWSLETTERDISPATCHER_SENTRY_DSN (sentry dsn value)
+- RER_NEWSLETTERDISPATCHER_REDIS_PORT (port where redis should listen. Default is 6379 but it's better to change it)
 
 
 Custom buildout configurations

app.py

@@ -33,7 +33,7 @@ def create_app(debug=True):
         format="[%(asctime)s] %(levelname)s - %(message)s",
     )
     try:
-        app.config.from_object("config.Config")
+        app.config.from_pyfile("config.py")
     except ImportStringError:
         logger.error("No config.py file found. Starting with standard configuration.")
 

base.cfg

@@ -30,4 +30,3 @@ eggs =
     rq
     sentry-sdk[flask]
     raven
-

config.py

@@ -0,0 +1,11 @@
+# -*- coding: utf-8 -*-
+import os
+
+MAIL_SERVER = os.environ.get("RER_NEWSLETTERDISPATCHER_MAIL_SERVER", default="")
+SENTRY_DSN = os.environ.get("RER_NEWSLETTERDISPATCHER_SENTRY_DSN", default="")
+MAIL_PORT = os.environ.get("RER_NEWSLETTERDISPATCHER_MAIL_PORT", default=25)
+MAIL_USERNAME = os.environ.get("RER_NEWSLETTERDISPATCHER_MAIL_USERNAME", default="")
+MAIL_PASSWORD = os.environ.get("RER_NEWSLETTERDISPATCHER_MAIL_PASSWORD", default="")
+
+# NOTE: Redis default port is 6379
+REDIS_PORT = os.environ.get("RER_NEWSLETTERDISPATCHER_REDIS_PORT", default="6379")