Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support winget #628

Closed
cjwijtmans opened this issue Apr 23, 2022 · 13 comments
Closed

support winget #628

cjwijtmans opened this issue Apr 23, 2022 · 13 comments

Comments

@cjwijtmans
Copy link

https://github.com/microsoft/winget-pkgs

@mekwall
Copy link

mekwall commented Jun 5, 2022

Anyone can add packages to winget but the package must have an installer/uninstaller specified in the manifest that winget can use. So this issue is blocked until an installer is added. Do you have any plans on doing that @Rem0o?

Edit: @cjwijtmans I suggest that you update the title to something like "Add installer so that this software can be added to package managers"

@cjwijtmans
Copy link
Author

cjwijtmans commented Jun 6, 2022

I am aware. By supporting winget one must create a MSIX package. Althought winget supports regular installers the ultimate goal for winget is to be MSIX package manager.

@Rem0o
Copy link
Owner

Rem0o commented Jun 6, 2022

Well, FanControl doesn't have any installer, since it's a portable exe.

@Rem0o
Copy link
Owner

Rem0o commented Jun 6, 2022

You could just curl the zip (https://github.com/Rem0o/FanControl.Releases/blob/master/FanControl.zip?raw=true) and that would work from the command line.

@mekwall
Copy link

mekwall commented Jun 6, 2022

@Rem0o Do you plan on adding a installer? It would be great to be able to keep it up-to-date with package managers like winget, scoop and chocolatey. Afaik they all require installers.

@Rem0o
Copy link
Owner

Rem0o commented Jun 6, 2022

@mekwall not on the roadmap, since its a portable app, I don't see the benefits of adding additional bulk for a single exe with dlls, plus it has auto-update already. I prefer keeping it as simple as possible.

@cjwijtmans
Copy link
Author

cjwijtmans commented Jun 6, 2022

@mekwall not on the roadmap, since its a portable app, I don't see the benefits of adding additional bulk for a single exe with dlls, plus it has auto-update already. I prefer keeping it as simple as possible.

A bit of a weird reply. Packages exist for a reason. So much so that microsoft created the MSIX packages. They allow tracking of files and (registry) settings. Packages could even run in a container or a sandbox for security and whatnot. Signing of EXE and license files.

https://docs.microsoft.com/en-us/windows/msix/package/create-app-package-with-makeappx-tool

MakeAppx pack /v /h SHA256 /d "C:\source\fancontrol\build" /p fancontrol_<version>.msix

I think with a couple of automated command lines it will not take much of your time. Sadly i dont have much experience with it myself yet.

@dschoerk
Copy link

i would love to see support for package managers like winget and chocolatey. it allows to quickly install the tool on a new pc. reducing the need to implement and maintain the update routine could even simplify the codebase.

@mekwall
Copy link

mekwall commented Oct 20, 2022

winget zip installs are in preview so anyone can create a PR with a manifest in the winget-pkgs repo to make it possible to install FanControl with winget.

@Rem0o Rem0o closed this as completed Feb 11, 2023
@Rem0o
Copy link
Owner

Rem0o commented Feb 11, 2023

Feel free to package whatever version in there.

@Silther
Copy link

Silther commented Mar 19, 2023

winget zip installs are in preview so anyone can create a PR with a manifest in the winget-pkgs repo to make it possible to install FanControl with winget.

I tried it with Komac, but unfortunately I couldn't do it. But if you have a bit of technical know-how, you should be able to do it very quickly.

@Silther
Copy link

Silther commented Mar 19, 2023

If you would then add a switch to disable the in-app updater, part of #1629 would also be solved.
Winget takes care of entering the version number, etc.
The winget download link should then always lead to the GitHub repo to keep the update process safe.

@Silther
Copy link

Silther commented Mar 19, 2023

and maybe a non-portable installer version is not that far away (#1410)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants