Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior wrt "missing" data entities #135

Closed
simleo opened this issue Sep 16, 2022 · 0 comments · Fixed by #136
Closed

Fix behavior wrt "missing" data entities #135

simleo opened this issue Sep 16, 2022 · 0 comments · Fixed by #136

Comments

@simleo
Copy link
Collaborator

simleo commented Sep 16, 2022

After the merge of #75, we allow data entities whose @id does not map to an existing file or directory, even if local. While this adds flexibility for use cases like #73, such crates are not supported by other libraries. Specifically, I got reports of crates generated with ro-crate-py that lead to errors when submission to WorkflowHub is attempted. The main issue is that it's too easy to add a "missing" data entity:

crate.add_file("/this/does/not/exist")  # Adds a File entity with @id = "exist"

This means it can be done involuntarily, by simply mistyping the path. It should be harder to do so (advanced usage), and we should issue a warning when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant