-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GUI images with low resolution #1581
Comments
Any of these images that don't have an SVG file are going to have to be traced. There was someone on discord who might have some of these. EDIT: It's also probably worth looking into if we can use svg files directly in Godot. I know Godot supports the format but I don't know if there's any performance cost. |
That seems like something Godot should fix. Could you see if you can find an open bug about this, and maybe open a bug / godot proposal for allowing to set the size for the slider? |
Looks like there is already a godot proposal for this godotengine/godot-proposals#660 |
It might be worth trying what Calinou suggested in that issue
Though it's probably best to try that after we have svgs for the stuff that needs to be replaced. |
Would that work correctly in exported game as well? I think I had a look at the test width and based on the tooltip for it didn't consider it a suitable choice. |
Theoretically it should. I'll test it out when I get the chance. |
@skyace65 Narotiza shared some svg files for the new editor and current microbe stage UI on the dev forum (which I used to get some new icons for the editor UI rework) https://drive.google.com/drive/folders/19B-ji46CMayUiXWGFdy7UM7Bl9AC70vZ?usp=sharing And here's the svg for the checkboxes and grabbers UI_Buttons.zip Also, the reproduction indicator bar, undo, redo and the plus icon are probably gonna be obsolete as it has been replaced in my branch with the newer ones. |
Looks like this should be easier to do now with this PR merged godotengine/godot#52137. I'll look into it this weekend but I'm making this comment in case I don't get around to it |
If Godot has now fixed this, that is excellent news. We plan to update to the latest Godot version next week or we might wait for 3.5 to be released. |
The fix is actually in 3.4 so thrive can use it right now. I'm currently testing it. |
Unfortunately this solution isn't going to work for thrive. For stuff like the main menu logo the scale property gets completely disregarded because it's in a center container. The slider grabber has no scale property so we're stuck with the "it gets too big" issue. I think we're just going to have to wait for proper SVG support. That is something wanted by the community but it's not being actively worked on as far as I know. |
'Been a while no ones cared about those images. Are they still a thing to care about? |
I still care that parts of the GUI are pixelated. And anyone with a high resolution monitor will be able to notice the weird different clarity of GUI elements on the same screen. |
That Is true as I do with my 1440p monitor. |
Yes, that's the original reason why things are low-res. Referring back to those Godot proposal and change linked above, it should now be possible to specify in the style the "expand" option for the texture, which contrary to the name also allows an image to be scaled down from its native resolution. If you can't find how to get it working some programmer may be needed to look into this. |
well i've tried to use that expand option but the icon keeps diappearing when I change value (so it works well)>save>quit>reopen. |
When expand is on there needs to be a minimum size set, otherwise the size ends up at 0x0 pixels so it disappears entirely. |
Noted. |
Seems like some of the listed elements are good already. The list might not be up to date? |
Which ones are already good? I'm asking so that I can double check those ones. A few comments on the icons you already posted:
|
List of already good thing (to me): the trashcan icon / button
May I ask you to rename the element list with the actual file name? I can't find some of them/not sure what is what |
agree
this uses the inbuilt Godot texture, which is very low res. We should do our own. This is currently hidden in the game as the microbe editor colour picker has these turned off.
agree
I think it is "NewIcon.png" which is 40x40
I'll see if I can find them and update the list. Edit: done adding names of files to the list |
The following things in the GUI are too low resolution at 4K and look blurry:
The buttons should be 240x240 to match what properly sized buttons currently are. Some of the other elements should be a bit larger, maybe up to 500 or even 1000?
Note: there might be places where changing the icon resolution breaks things so there's a chance that godot GUI scenes need tweaking as well as just the image files.
The text was updated successfully, but these errors were encountered: