Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node.js 14 and update dependencies #46

Merged
merged 16 commits into from
Oct 10, 2023
Merged

Require Node.js 14 and update dependencies #46

merged 16 commits into from
Oct 10, 2023

Conversation

afonsojramos
Copy link
Contributor

@afonsojramos afonsojramos commented Aug 25, 2023 •
edited by Richienb
Loading

We might want to remove Node 14 and 16 as it is almost unsupported as per https://github.com/nodejs/release#release-schedule.

Fixes #49

Richienb
Richienb requested changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@Richienb Richienb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

package.json Outdated Show resolved Hide resolved
@Richienb Richienb changed the title chore: add node 18 & 20 Require Node.js 14 and update dependencies Oct 9, 2023
Richienb
Richienb requested changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@Richienb Richienb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further updates have since been released for the dependencies, must be updated here
#49

@afonsojramos afonsojramos requested a review from Richienb October 9, 2023 09:28
Richienb
Richienb reviewed Oct 9, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
Richienb
Richienb reviewed Oct 9, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@afonsojramos afonsojramos requested a review from Richienb October 9, 2023 23:22
Richienb
Richienb requested changes Oct 10, 2023
View reviewed changes
Copy link
Owner

@Richienb Richienb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

citing sources

index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
@afonsojramos @Richienb
chore: add sources
9129636 
Co-authored-by: Richie Bendall <richiebendall@gmail.com>
@afonsojramos afonsojramos requested a review from Richienb October 10, 2023 12:58
Richienb
Richienb requested changes Oct 10, 2023
View reviewed changes
Copy link
Owner

@Richienb Richienb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops mb

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@afonsojramos afonsojramos requested a review from Richienb October 10, 2023 13:01
@Richienb Richienb merged commit 6c90ae3 into Richienb:main Oct 10, 2023
3 checks passed
@Richienb
Copy link
Owner

Thanks!

@Richienb Richienb mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richienb Richienb Awaiting requested review from Richienb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependencies
2 participants
@afonsojramos @Richienb