Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeGeneration CSharp DateFormatConverter.liquid does not respect setting for DateType #1526

Closed
AroglDarthu opened this issue Jun 2, 2022 · 0 comments · Fixed by #1527
Closed

CodeGeneration CSharp DateFormatConverter.liquid does not respect setting for DateType #1526

AroglDarthu opened this issue Jun 2, 2022 · 0 comments · Fixed by #1527

Comments

@AroglDarthu
Copy link
Contributor

AroglDarthu commented Jun 2, 2022 •
edited
Loading

When generating the DateFormatConverter, it now always uses System.DateTime. It should use the type specified for the CSharpGeneratorSettings.DateType (which defaults to System.DateTimeOffset).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DateFormatConverter System.Text.Json to respect DateType setting AroglDarthu/NJsonSchema
1 participant
@AroglDarthu