Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NJsonSchema.Attributes package #1628

Closed
trejjam opened this issue Sep 27, 2023 · 2 comments · Fixed by #1641
Closed

Create NJsonSchema.Attributes package #1628

trejjam opened this issue Sep 27, 2023 · 2 comments · Fixed by #1641

Comments

@trejjam
Copy link
Sponsor Contributor

trejjam commented Sep 27, 2023

Hi,
are you open to extracting NJsonSchema/Attributes into a standalone package?

My motivation is that these attributes are used on the Domain/Contract level and most of your solution depends on these. That is fine by itself, but NJsonSchema has its dependencies like Newtonsoft.Json which we would like to push out of our codebase.

I know that Newtonsoft is heavily used in the library and I am not asking to remove it :) I am ok to use it in places where it makes sense.

If you are open to it, I can prepare a PR for it

@RicoSuter
Copy link
Owner

I think that's a good idea, NSwag also has this with the NSwag.Annotations package so maybe we should also call it NJsonSchema.Annotations

@RicoSuter
Copy link
Owner

v11.0.0-preview006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants