Correct unused variables

[Se-C12]

Some variables are unused in code.
Maybe error-prone has a detector for that

[Riduidel]

Seems like it exists ! https://errorprone.info/bugpattern/UnusedVariable

[Helielzel]

• Add variables in cdi-config-extension,
• create method with unused parameter
• modify the config of error prone in the root pom until the message appears

[Helielzel]

relevant ? -> google/error-prone#985

relevant ? if yes, how to read that ? -> https://mvnrepository.com/artifact/com.google.errorprone

So far i've tested the plugin with mvn install, is there something better ?

[Helielzel]

aadarchi does not use javac doesn't it ? Because in an exemple I found, there's a tag in the pom like this one (in configuration) : <compilerId>javac-with-errorprone</compilerId> -> build fails
and this one : <forceJavacCompilerUse>true</forceJavacCompilerUse>

[Helielzel]

In fact it's much easier if I copy paste all the config tag here :

<configuration>
                <compilerArgs>
                    <arg>-d</arg>
                    <arg>${project.build.directory}/classes-ep</arg>
                </compilerArgs>
                <compilerId>javac-with-errorprone</compilerId>
                <forceJavacCompilerUse>true</forceJavacCompilerUse>
                <!-- Erroneously inverted logic... for details, see
                https://jira.codehaus.org/browse/MCOMPILER-209 -->
                <useIncrementalCompilation>true</useIncrementalCompilation>
</configuration> `

[Riduidel]

So far i've tested the plugin with mvn install, is there something better ?

Yes, you can use mvn compile

[Riduidel]

aadarchi does not use javac doesn't it ?

aadarch uses maven-compiler-plugin, which in turn uses javac under the hood

[Helielzel]

Still compiles with useless class & variables (mvn clean compile -pl :cdi-config-extension)