Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error when kroki server is unreachable #333

Open
Riduidel opened this issue Mar 13, 2023 · 2 comments
Open

Log error when kroki server is unreachable #333

Riduidel opened this issue Mar 13, 2023 · 2 comments
Labels
effort: 2 good first issue Good for newcomers. state: approved Approved to proceed. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. work: obvious The situation is obvious, best practices used.

Comments

@Riduidel
Copy link
Owner

This will make analtsis easier (and maybe already implemented in asciidoctor-kroki)
This was referenced Mar 13, 2023
Closed
Open
@Riduidel
Copy link
Owner Author

Requires an explicit definition of kroki server url in pom, but seems feasible

@Riduidel
Copy link
Owner Author

Finally found a good workaround : why not define a verify level plugin that will check that the value of kroki url is correct (and test it with an http call)

@Riduidel Riduidel added good first issue Good for newcomers. work: obvious The situation is obvious, best practices used. state: approved Approved to proceed. effort: 2 priority: 2day type: feature Brand new functionality, features, pages, workflows, endpoints, etc. and removed difficulty-🐛🐛 priority: 2day labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: 2 good first issue Good for newcomers. state: approved Approved to proceed. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. work: obvious The situation is obvious, best practices used.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Riduidel @Helielzel