Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(items-list): add new card view #479

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(items-list): add new card view #479

wants to merge 3 commits into from

Conversation

Iqro-dev
Copy link
Contributor

@Iqro-dev Iqro-dev commented Aug 9, 2024

closes #478

@Iqro-dev Iqro-dev added the enhancement New feature or request label Aug 9, 2024
@Iqro-dev Iqro-dev self-assigned this Aug 9, 2024
@Iqro-dev Iqro-dev linked an issue Aug 9, 2024 that may be closed by this pull request
create new card view #478
Open
@vercel Vercel
Copy link

vercel bot commented Aug 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rigtch-fm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 1:20am
rigtch-fm-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 1:20am

@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from 441339f to 809dab4 Compare August 9, 2024 14:35
@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from 809dab4 to 017961a Compare October 7, 2024 09:11
@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from 017961a to b267a38 Compare October 7, 2024 09:17
@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from b267a38 to a7c0450 Compare October 7, 2024 09:19
@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from a7c0450 to e4f67c8 Compare October 7, 2024 10:05
@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.64%. Comparing base (e5de8e9) to head (1b958b2).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
app/components/items/cards/item-card.tsx 80.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   44.39%   44.64%   +0.25%     
==========================================
  Files         174      174              
  Lines        5068     5091      +23     
  Branches      245      381     +136     
==========================================
+ Hits         2250     2273      +23     
  Misses       2818     2818

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from e2d24bf to c60e67a Compare October 8, 2024 01:15
@Iqro-dev Iqro-dev added the help wanted Extra attention is needed label Oct 8, 2024
@Iqro-dev
Copy link
Contributor Author

Iqro-dev commented Oct 8, 2024

the grid positioning is done but the problem is the static size of images
image
attention needed

@Iqro-dev Iqro-dev force-pushed the 478-create-new-card-view branch from c60e67a to 1b958b2 Compare October 8, 2024 01:18
@Mnigos Mnigos added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Iqro-dev Iqro-dev

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
rigtch.fm
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create new card view
2 participants
@Iqro-dev @Mnigos