Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): move arrows up and extend text width #633

Conversation

Iqro-dev
Copy link
Contributor

closes #632

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rigtch-fm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 5:01pm
rigtch-fm-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 5:01pm

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.77%. Comparing base (8e77cb7) to head (5951361).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   40.85%   40.77%   -0.09%     
==========================================
  Files         191      191              
  Lines        5059     5057       -2     
  Branches      404      401       -3     
==========================================
- Hits         2067     2062       -5     
- Misses       2992     2995       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from b5a620b to d0fd894 Compare October 24, 2024 13:23
@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from d0fd894 to 9eddc5b Compare October 24, 2024 13:27
@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from 9eddc5b to 487ac61 Compare November 18, 2024 18:50
@Iqro-dev Iqro-dev requested a review from Mnigos November 18, 2024 18:51
Copy link
Member

@Mnigos Mnigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this change was to make the name longer
Screenshot 2024-11-23 at 14 20 14

@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from b347fff to 700f727 Compare December 19, 2024 16:33
@Mnigos Mnigos merged commit 16e734e into main Dec 19, 2024
2 of 4 checks passed
@Mnigos Mnigos deleted the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch December 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

make name and progress bar full width on mobile and move arrows in carousel
2 participants