Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils._svnRevision is broken due to using undefined function getInfo #68

Open
r-owen opened this issue Jan 13, 2016 · 8 comments
Open

Comments

@r-owen
Copy link
Collaborator

r-owen commented Jan 13, 2016

No description provided.

@migueldvb
Copy link
Contributor

This time it looks that this was not broken because of my changes :) Probably this function is not needed any more?

@timj
Copy link
Collaborator

timj commented Jan 13, 2016

From what I can tell the use of getInfo was added in commit 4ada4fc (from 2008) and even in that checkout there is no definition of getInfo.

@timj
Copy link
Collaborator

timj commented Jan 13, 2016

Am I correct in thinking that nothing calls _svnRevision anyhow?

@migueldvb
Copy link
Contributor

Yes, I think it is safe to remove _svnRevision.

@mjuric
Copy link
Collaborator

mjuric commented Jan 13, 2016

Just to be on the safe side -- @r-owen, how did you find this? Did it trigger a problem with everyday work, or did it come out of a linter?

@r-owen
Copy link
Collaborator Author

r-owen commented Jan 13, 2016

pyflakes found it. I strongly suspect the function is not being used (since it is guaranteed to fail if run) but I didn't bother to check.

@timj
Copy link
Collaborator

timj commented Jan 13, 2016

Nothing in the source references that function. It can be removed.

@mjuric
Copy link
Collaborator

mjuric commented Jan 13, 2016

+1 to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants