-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPParser reuse causes confusing contexts. #1
Comments
I can confirm this. See also nodejs/node#5573, my guess is that the PR won't land, but the issue will be fixed when AsyncWrap gets finalized. I also gave your code a 30 sec look. I think it's correct, but I would suggest that you use |
@AndreasMadsen Thanks for your review. I found And then, I came across the nodejs/node-eps#18 you referenced and was surprised that there are so many upcoming changes. |
Yes, there is alot going on. Developing an API like AsyncWrap is a time consuming process and we can't simply create an API and hope for the best. The proposed API (eps) is the results from what we have learned from the current implementation, which have purposely been kept unofficial such that we could change it. |
@AndreasMadsen Understood. Looking forward to the next release so that we can make Zone a really working infrastructure that powers transactional scenarios like web server, data persistence etc. |
Failing test case: https://github.com/RobinQu/async-zone/blob/master/test/http_test.js#L70
My guess:
init
hook is only called the first time it's created and not called after reuse.Run with
DEBUG
The text was updated successfully, but these errors were encountered: