Message count in statistics is strange

[janrudolph]

Description:

In the admin info panel Rocket.chat displays usage statistics. However, it seems that the message count is not correct.

Server Setup Information:

• Version of Rocket.Chat Server: 0.61.1

Actual behavior:

=> as you see, the sum of all message is not correct if

Total Messages = Total Messages in Channels + Total Messages in Private Groups + Total Messages in Direct Messages + Total Messages in Livechats

[kaiiiiiiiii]

The total message count is different because the calculation of the values is based on two different tables. The best thing would be to sum up the four already calculated values to get the exact total message count. However, I am not sure if the message count stored in the room object is always up to date.

Rocket.Chat/packages/rocketchat-statistics/server/functions/get.js

Lines 35 to 40 in c978136

	// Message statistics
	statistics.totalMessages = RocketChat.models.Messages.find().count();
	statistics.totalChannelMessages = _.reduce(RocketChat.models.Rooms.findByType('c', { fields: { 'msgs': 1 }}).fetch(), function _countChannelMessages(num, room) { return num + room.msgs; }, 0);
	statistics.totalPrivateGroupMessages = _.reduce(RocketChat.models.Rooms.findByType('p', { fields: { 'msgs': 1 }}).fetch(), function _countPrivateGroupMessages(num, room) { return num + room.msgs; }, 0);
	statistics.totalDirectMessages = _.reduce(RocketChat.models.Rooms.findByType('d', { fields: { 'msgs': 1 }}).fetch(), function _countDirectMessages(num, room) { return num + room.msgs; }, 0);
	statistics.totalLivechatMessages = _.reduce(RocketChat.models.Rooms.findByType('l', { fields: { 'msgs': 1 }}).fetch(), function _countLivechatMessages(num, room) { return num + room.msgs; }, 0);

I'll submit a PR for that.

[engelgabriel]

Ref: #10726

[subham103]

Previously, the message count for every channel is increased upon message addition but is not updated upon the deletion of a message #12610. Now that I have linked a pr #16650 on this issue we can save/fetch the actual message count of any channel onto/from the database.

So it will be better if we sum up the four values to get the exact total message count.

I want to work on this issue