Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplace of '@' in the directory -> users page. #10398

Closed
lunaticmonk opened this issue Apr 10, 2018 · 3 comments · Fixed by #10454
Closed

Misplace of '@' in the directory -> users page. #10398

lunaticmonk opened this issue Apr 10, 2018 · 3 comments · Fixed by #10454
Assignees
Milestone

Comments

@lunaticmonk
Copy link
Contributor

Description:

Server Setup Information:

  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method(snap/docker/tar/etc):
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • Node Version:
  • mongoDB Version:

Steps to Reproduce:

  1. Head over to the directory search for users.
  2. Under the name column, before the name of the user, the "@" symbol looks weird.

Actual behavior:

image

Expected behavior:

Instead of placing it in front of the name, it should be in front of the username in the second column.

@karlprieb What are your opinions on this one?

@karlprieb
Copy link
Contributor

I get it, maybe we should change the first column to Username (with avatar, @ icon and username) and the second column should be the Name column.

@sumedh123 do you want to make a PR for that?

@lunaticmonk
Copy link
Contributor Author

lunaticmonk commented Apr 10, 2018

@karlprieb Okay, I will do it.

@karlprieb
Copy link
Contributor

@sumedh123 thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants