-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong font-family order #11037
Comments
Found that while messing with userstyle that disables 'picturized' emojis and returns their text content back, and during investigation found there are more quirks than expected: https://imgur.com/a/eh8N3sg The outcome is that for some fonts handles some ways of encoding better and that "Segoe UI Emoji" has most probably some kind of flaw (on my machine). Resorting to "Segoe UI" alone seems to be the best solution for this certain problem, although it takes away the colours in emojis. But it is quite unrelated to RC since you are using own robust imagery :] |
Looking at ↑ pull (https://github.com/RocketChat/Rocket.Chat/pull/11191/files#diff-39d471521e300f53e48eec47f92c0401R69) this will technically mean given version will have basic windows font changed from Arial to Segoe UI, which has different metrics and could potentially surprise users. |
Rocket.Chat/packages/rocketchat-theme/server/variables.js
Line 69 in 98c3ed5
For some (quite understandable) reason, on Windows 10 such declaration produces funky results for emoji and /or combining characters.
, Arial, sans-serif
should be at the end of such declaration, which should be from specific to generic font faces, here the order of Segoes is reversed and probably shadowed by the generic family.The text was updated successfully, but these errors were encountered: