Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide room confirmation shows "undefined" instead of user name (only DM, only via Room Info sidebar) #14159

Closed
2 tasks done
BobKnip opened this issue Apr 16, 2019 · 1 comment · Fixed by #14415
Closed
2 tasks done

Comments

@BobKnip
Copy link

BobKnip commented Apr 16, 2019

My Setup

  • Operating System: Windows 10
  • App Version: 2.15.1
  • Installation type: EXE
  • I have tested with the latest version
  • I can simulate the issue easily

Description

Hide room confirmation shows "undefined" instead of user name (only DM, only via Room Info sidebar).

  • Does NOT work correctly : Room info (sidebar, right) > "Hide" (button at the bottom):
    'Are you sure you want to hide the discussion with "undefined"?'
    (The result of confirming hiding the room is as expected.)
    This bug only applies to Direct Message rooms. (For Group and Channel, the correct text is shown via room context menu and Room Info sidebar.)

  • DOES work correctly: Room context menu (three dots, left) > "Hide Room" (menu item):
    'Are you sure you want to hide the discussion with "<ACTUAL_NAME>"?'
    (<ACTUAL_NAME> is placeholder; e.g.: "Naomi Mc Nameface".)

  • BTW: These seemingly identical functions have slightly different texts for their options: menu item "Hide Room" and button "Hide". I know the latter is already in context of the "Room Info" sidebar, but you might as well rename the button "Hide Room" for consistency. Also, a new user might think the "Hide" button hides the Room Info sidebar.

Current Behavior

When confirming hiding a DM room via the Room Info sidebar, "undefined" is shown as the user name.

Expected Behavior

When confirming hiding a DM room via the Room Info sidebar, the actual user name should be shown.

@tassoevan tassoevan transferred this issue from RocketChat/Rocket.Chat.Electron Apr 16, 2019
@tassoevan
Copy link
Contributor

@BobKnip I transferred this issue since it looks like a Rocket.Chat server bug. Can you please fill a bug description following this template (https://raw.githubusercontent.com/RocketChat/Rocket.Chat/develop/.github/ISSUE_TEMPLATE/bug_report.md)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants