Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid user" error when terminating SAML session on logout #14200

Closed
unixtam opened this issue Apr 19, 2019 · 5 comments · Fixed by #17227
Closed

"Invalid user" error when terminating SAML session on logout #14200

unixtam opened this issue Apr 19, 2019 · 5 comments · Fixed by #17227

Comments

@unixtam
Copy link
Contributor

unixtam commented Apr 19, 2019

Description:

After logging out via SAML, a red error notification pops up in the upper right corner of the page reading "Invalid User" if the SAML session is configured to be terminated on logout.

Steps to reproduce:

  1. set up SAML
  2. make sure "Logout Behaviour" is set to "Terminate SAML-Session"
  3. log in a SAML user
  4. log out the SAML user
  5. see error pop up on the login screen

Server Setup Information:

  • Version of Rocket.Chat Server: issue present both in 0.74.3 and the current develop branch.
@ngulden
Copy link
Contributor

ngulden commented May 10, 2019

I have the same behavior und used Rocket.Chat 1.0.2 Docker image.

@cb3inco
Copy link

cb3inco commented Jul 17, 2019

Same issue here. 1.2.1 Docker image.

Here is the log error I get on a logout:

Exception while invoking method 'samlLogout' TypeError: Cannot read property 'services' of undefined at MethodInvocation.samlLogout (app/meteor-accounts-saml/server/saml_server.js:61:25) at MethodInvocation.methodsMap.(anonymous function) (app/lib/server/lib/debug.js:62:34) at MethodInvocation.methodMap.(anonymous function) (packages/rocketchat_monitoring.js:2731:30) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1767:12) at DDP._CurrentMethodInvocation.withValue (packages/ddp-server/livedata_server.js:719:19) at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1304:12) at DDPServer._CurrentWriteFence.withValue (packages/ddp-server/livedata_server.js:717:46) at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1304:12) at Promise (packages/ddp-server/livedata_server.js:715:46) at new Promise () at Session.method (packages/ddp-server/livedata_server.js:689:23) at packages/ddp-server/livedata_server.js:559:43

@cb3inco
Copy link

cb3inco commented Jul 17, 2019

Another Log item: Exception in callback of async function: { Error: [Unable to Validate Logout Request] at app/meteor-accounts-saml/server/saml_server.js:356:14 at app/meteor-accounts-saml/server/saml_utils.js:365:11 at InflateRaw.onEnd (zlib.js:131:5) at emitNone (events.js:111:20) at InflateRaw.emit (events.js:208:7) at endReadableNT (_stream_readable.js:1064:12) at _combinedTickCallback (internal/process/next_tick.js:138:11) at process._tickDomainCallback (internal/process/next_tick.js:218:9) isClientSafe: true, error: 'Unable to Validate Logout Request', reason: undefined, details: undefined, message: '[Unable to Validate Logout Request]', errorType: 'Meteor.Error' }

@cb3inco
Copy link

cb3inco commented Jul 17, 2019

Interestingly if I switch to the setting: Only logout from Rocket.Chat - the error goes away.

@Hudell
Copy link
Contributor

Hudell commented Aug 21, 2019

Related: #14881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants