Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work specific symbols in url #15213

Closed
vdvas opened this issue Aug 20, 2019 · 3 comments
Closed

does not work specific symbols in url #15213

vdvas opened this issue Aug 20, 2019 · 3 comments
Labels
stat: stale Stale issues will be automatically closed if no activity

Comments

@vdvas
Copy link

vdvas commented Aug 20, 2019

Description:

User can't follow url in conversation if it have specific symbols like "{".
If I send or receive message with url link, like http://example.com/asd{asd and then follow this link it's open in browser link http://example.com/asd and don't work.
when symbol "{" became in url after this not recognize like url part.

Steps to reproduce:

  1. Go to 'chat' and choose user to conversation.
  2. Tape "http://example.com/asd{asd" and send message
  3. See only "http://example.com/asd" like url and blue letters and other part is black letters.

Expected behavior:

All url "http://example.com/asd{asd" must be blue letters and follow in browser as "http://example.com/asd{asd"

Actual behavior:

Only part of url is recognized as a link.

Server Setup Information:

  • Version of Rocket.Chat Server: 1.2.3
  • Operating System: Ubuntu 18.04
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v8.11.3
  • MongoDB Version: 3.4.20

Additional context

Relevant logs:

@wreiske
Copy link
Contributor

wreiske commented Aug 20, 2019

Possibly related to gregjacobs/Autolinker.js#268

Looks like the URL doesn't parse correctly here: http://greg-jacobs.com/Autolinker.js/examples/index.html

To be fair, { should be http://example.com/asd%7Basd if you're trying to share a link. If you use http://example.com/asd%7Basd it will work.

@reetp
Copy link

reetp commented Sep 12, 2019

Related to the parser as well:

#15347

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Jul 24, 2020
@github-actions github-actions bot closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: stale Stale issues will be automatically closed if no activity
Projects
None yet
Development

No branches or pull requests

3 participants