-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global search across channels #1615
Comments
I was going to ask the same... It's really a must. |
+1 Most of the competing products offer this useful feature. |
+1 |
1 similar comment
+1 |
Same here ! We've been asking ourselves "where it could be" without even thinking it was not an existing functionality... That's a real drawback I'm pretty sure the awesome team here will take care of ! Many thanks for your good work guys ;) |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
Seems like a pretty important feature... I'm surprised it doesn't exist. |
+1 |
8 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
Just looking for how to activate this functionality, I find this issue. So please, think about it :) |
+1 - Really, really need this function. |
+1 |
5 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
As much as I appreciate all the +1 it doesn't seem as if a developer is willing to introduce this feature, right? |
Anyone else willing to add some dollars to the bounty so that we can finally get this implemented? https://www.bountysource.com/issues/28998888-global-search-across-channels |
@jusfeel actually it's not a big deal, I tried this just now, apart from meteor/meteor#8057 issue, everything else is very straightforward. The way it's currently done is: client sends roomId to server, I changed it to send null in this case (of course without breaking existing stuff by using optional parameter), on server it's checking if user has access to that channel (which might be null in our case). When searching for entire conversation, I first select all room user has access to, then search for the messages in those rooms. It's pretty straightforward upto now. What remains is: when we display the result, right now we can just click on hand arrow and it shows in that channel, now it should navigate away from that channel, since this is the first time I've touched meteor, I'll need a little time for this part :) Any suggestions are welcome :) |
searching and displaying is done, now all I need to do is to show the message when clicked. This is my first time trying to do meteor and this template, if someone familiar with this, I just need to change the current room. any suggestions welcome :) |
Anybody else willing to upgrade the bounty, I just added $200 - https://www.bountysource.com/issues/28998888-global-search-across-channels |
+1 |
I have somehow-working solution on my fork (https://github.com/savikko/Rocket.Chat.git), please clone and test and share your experiences with that. |
+1 |
Thanks for adding your vote. If you can, please add to the bounty so that we can finally get this in place - Bountysource |
The bounty is now nearly $800, and someone has had a solution ready for testing since August. Can someone please tell me what's stopping this from happening? |
Reason for not happening from my side has been global busyness :) |
Hi Savikko |
Thanks for your kind words. |
Hi all! |
I just tried the beta, seems to work ok, but our team is small, so not likely to have performance issues. Thank you for doing this, @savikko . |
@savikko Bug: If I scroll through the list of global search results, if I scroll to the very end, the list suddenly reverts to the current channel only. |
@savikko Feature: The search results are updated as I type the search string. Should they also update if I tick or untick the Global Search option? |
@pshute : I'm not alone here doing this, thanks @cyberhck for starting this and @rodrigok for getting it running. Search update (un)ticking option is not implemented at the moment, it should be done at the same time as layout of the checkbox would be changed. I wouldn't mind if there would be "loading" spinner when searching. I can confirm that when scrolling (until the paging triggers) to the bottom, paging does not recognize that global search was chosen. |
Aloha! Firstly, I want to thank everybody that worked on this great feature, I'm using it and it works like a charm. In second place, I wanted to make a consideration that is also related somehow to performance but it's more about usability... |
Our current setup: |
Many thanks @savikko! |
As far as I can tell, search right now functions on a per-channel basis. Is that true? Is there a way to search all chat history globally? This seems extremely useful, and probably not hard to implement.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: