Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Discussion filter is shown even though the functionallity is disabled #17621

Closed
kaiiiiiiiii opened this issue May 12, 2020 · 1 comment · Fixed by #17963
Closed

[BUG] Discussion filter is shown even though the functionallity is disabled #17621

kaiiiiiiiii opened this issue May 12, 2020 · 1 comment · Fixed by #17963
Assignees
@dudizilla
Labels
ui/ux
Milestone
3.4.0

Comments

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented May 12, 2020 •
edited
Loading

Bug was introduced despite notice in the initial PR:
#17103 (comment)

2020-05-12 13_41_14- NEW Merge Sort List and View Mode menus and improve its UI_UX by ggazzo · Pull

Cheers
@kaiiiiiiiii kaiiiiiiiii changed the title [BUG] Discussion filter is shown even though it's disabled [BUG] Discussion filter is shown even though the functionallity it's disabled May 12, 2020
@kaiiiiiiiii kaiiiiiiiii changed the title [BUG] Discussion filter is shown even though the functionallity it's disabled [BUG] Discussion filter is shown even though the functionallity is disabled May 12, 2020
@dudizilla dudizilla added the ui/ux label Jun 4, 2020
@ggazzo ggazzo added this to the 3.4.0 milestone Jun 4, 2020
@ggazzo
Copy link
Member

ggazzo commented Jun 4, 2020

@kaiiiiiiiii as far I can see you are right about the bug, but not about the comment ...

... despite notice in the initial PR...
looking your image we can see a "pending" pending tag, that means you didn't finished your review
maybe you are used with comments over reviews and for some reason you clicked on the wrong place, I'm sorry if you felt ignored/alone but its not my fault(at least this time), feel free to comment/review any PR that I make and I will be happy to take it in consideration....

cheers

@ggazzo ggazzo mentioned this issue Jun 19, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dudizilla dudizilla

Labels
ui/ux
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

[FIX] Discussion sort option even with discussions disabled RocketChat/Rocket.Chat
3 participants
@kaiiiiiiiii @ggazzo @dudizilla