Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purged threads still show as unread #18419

Closed
sinteur opened this issue Jul 29, 2020 · 6 comments · Fixed by #18944
Closed

Purged threads still show as unread #18419

sinteur opened this issue Jul 29, 2020 · 6 comments · Fixed by #18944
Labels
feat: prune messages stat: triaged Issue reviewed and properly tagged type: bug

Comments

@sinteur
Copy link

sinteur commented Jul 29, 2020

Description:

When threads were introduced, we played around with it a bit and disabled it. I had two unread comments in a thread, but after disabling threads the unread counter for the channel was gone. Many releases later, suddenly there was an unread counter for a channel despite the fact that I had read all messages in the channel. Some experimenting later it turned out that when I re-enabled threading, the thread icon had a two unread messages marker. However, since we also have pruning enabled, the old messages were gone, and could not be read, so I am stuck with a "2" badge on the channel that I cannot get rid of.

Steps to reproduce:

  1. enable threading
  2. have unread messages in a thread
  3. disable threading
  4. wait until after pruning.

Expected behavior

Unread badges disappear along with pruned messges/threads.

Actual behavior

Unread badges are kept after pruning and cannot be removed as the messages/threads no longer exists.

  • Version of Rocket.Chat Server: 3.5.0

  • Operating System: linux 3.16.0-10-amd64

  • Deployment Method: docker

  • Number of Running Instances: 2

  • DB Replicaset Oplog: enabled

  • NodeJS Version: v12.16.1

  • MongoDB Version: 4.0.16

  • Desktop App or Browser Version: Any browser. Safari and firefox tested

  • Operating System: Mac OS Catalina

@close-issue-app
Copy link

This issue was closed because it does not use any of our issue templates. Please make sure to use one of the suggested templates.

@magnetic5355
Copy link

Docker 3.5.0

Similar: We have unread thread counts on channels that we cannot clear.

When clicking the channel, selecting threads and filtering for unread, threads appear however opening them does not clear the counter leaving a permanent unread count.

@lyz-code
Copy link

We have a similar problem with 3.5.1. Now you are forced to jump into the thread so the notifications are marked as read

@magnetic5355
Copy link

Is there a plan to hotfix this? The issue is more noticeable for our user base on 3.6. The rooms with phantom unread counts stay in unread rooms or highlighted on mobile now . Mark as read does nothing creating a lot of confusion on new messages.

@magnetic5355
Copy link

magnetic5355 commented Sep 30, 2020

Issue still exists - this is the counter after pruning channel to empty. Prior to 3.7 prune did not work on rooms with stuck unread counters - so progress on the issue

image

@NotACreativeUsername
Copy link

Issue is effecting my end users as well. Windows 10 enterprise, Rocket chat version 2.17.11/3.0/3.0.1 and server version Version 3.6.3

@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: prune messages stat: triaged Issue reviewed and properly tagged type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants