Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History not loading after update to 5.3 #27372

Closed
shevchukma opened this issue Nov 27, 2022 · 2 comments · Fixed by #27391
Closed

History not loading after update to 5.3 #27372

shevchukma opened this issue Nov 27, 2022 · 2 comments · Fixed by #27391

Comments

@shevchukma
Copy link

Description:

After updating from version 4.8.6 to version 5.3.3, chats with a large number of messages in threads do not load history. I get the error "Error, to many requests. Please slow down..."
After that, the download circles flash, but nothing else downloads. Unable to load history.
In other chats where there are not many messages in the threads, the chat history is loaded.
I tried changing the Rate Limiter values, but that didn't work. The Rate Limiter is now at its default value.

Steps to reproduce:

  1. Open a chat with a large number of messages in threads.
  2. An error appears, the chat content is not loading.

Expected behavior:

The chat history is loaded even if there are threads with a large number of messages in the chat.

Actual behavior:

Chat history does not load if it has a large number of messages in many threads
Below is an example video.
loadcontent

Server Setup Information:

  • Version of Rocket.Chat Server: 5.3.3
  • Operating System: Oracle Linux 8.5
  • Deployment Method: docker
  • Number of Running Instances: 20
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v14.19.3
  • MongoDB Version: 5.0.14

Client Setup Information

  • Desktop App or Browser Version: Desktop App 3.8.14, Chromium 103.0.5060.53
  • Operating System: Windows 11. Debian 11.

Additional context

Version 4.8.* and previous versions did not have this problem.

Relevant logs:

image

@ankar84
Copy link

ankar84 commented Nov 28, 2022

Confirm that bug.
Looks like every thread message create separate REST API request, and if amount of such messages a big, then Rate Limiter blocks it. That behavior must be fixed.
cc @dudanogueira @debdutdeb to show that issue to team.

@dudanogueira
Copy link
Contributor

Fix was included in 5.4.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants