Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to join room multiple times #316

Closed
warcode opened this issue Jul 18, 2015 · 3 comments
Closed

Possible to join room multiple times #316

warcode opened this issue Jul 18, 2015 · 3 comments

Comments

@warcode
Copy link
Contributor

warcode commented Jul 18, 2015

A user should never be able to have multiple entries in a room.

Due to the routing being broken (?) when I go to /room/GENERAL and click JOIN in the preview mode I get added to the room multiple times. This should check if the user is already in the room before adding it again.

@marceloschmidt
Copy link
Member

I cannot reproduce this, as the JOIN button doesn't show up. @warcode can you test this again and let us know if this is still a problem? Thanks!

@warcode
Copy link
Contributor Author

warcode commented Jul 19, 2015

This might be part of a different issue.

  1. Leave/Hide the General channel
  2. Go to more channels
  3. All channel links go to /room instead of /room/id
  4. Manually type in /room/GENERAL
  5. Click Join button fails.

This issue appeared after the switch from Iron to Flow.

@marceloschmidt
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants