Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTR: raw/encrypted binary messages displayed after OTR session is finished #6526

Open
localguru opened this issue Mar 29, 2017 · 9 comments
Open
Assignees
Milestone

Comments

@localguru
Copy link
Contributor

localguru commented Mar 29, 2017

Rocket.Chat Version: 0.52.0, 2.2.0

I still see the raw/encrypted messages of some users after the OTR session is finished. A restart doesn't remove the messages.

rc_otr_bug

@marceloschmidt
Copy link
Member

Hi @localguru do you have steps to reproduce the problem?

@marceloschmidt
Copy link
Member

Can anyone confirm this is still happening?

@marceloschmidt marceloschmidt added this to the Short-term milestone May 8, 2017
@mddvul22
Copy link

I see this on 0.55.1

@gregs007
Copy link

gregs007 commented Jun 7, 2017

Still see this on 0.56.0. I think what causes it is when you are in the middle of OTR session and try to send a screenshot. Nothing happens in the OTR session, but it's the only thing I can see that's been different between OTR sessions that disappear and OTR sessions that continue to display RAW binary chats. Interestingly enough the screenshot will not show when you're in the OTR session, but it will show in the middle of the binary conversation after you restart/reload the client.

@gregs007
Copy link

gregs007 commented Jun 20, 2017

Also what causes this is when you press up arrow to edit a message while in an OTR session. As soon as you do, the edited message changes to binary output and after the session is over, the binary messages will continue to exist in the database.

@mlanner
Copy link

mlanner commented Aug 2, 2017

I have a similar problem, I think. I'm running 0.57.2.

I start the OTR, use it, close the OTR session. The messages stay visible until I restart the RC app.

@PKeidel
Copy link

PKeidel commented Jan 24, 2018

Problem is still there in 0.60.3.

It also occours, if you are in an OTR session and edit your message. Then the JSON is shown instead of the new edited message

@mddvul22
Copy link

@PKeidel I think this will be getting resolved by the new OTR implementation:
#7181

@localguru
Copy link
Contributor Author

This is still a bug in RC 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants