Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n in sendEmailOnMessage.js not working #7313

Closed
localguru opened this issue Jun 22, 2017 · 5 comments
Closed

i18n in sendEmailOnMessage.js not working #7313

localguru opened this issue Jun 22, 2017 · 5 comments
Assignees
Labels
feat: i18n stat: triaged Issue reviewed and properly tagged type: improvement
Milestone

Comments

@localguru
Copy link
Contributor

localguru commented Jun 22, 2017

Rocket.Chat Version: 0.57.0-develop and 0.56.0

Sending emails on message are not localized in packages/rocketchat-lib/server/lib/sendEmailOnMessage.js. My global locale and user profile is set to "de", but I receive email with "en" localization, e.g. Subject "[Rocket.Chat] You have been direct messaged by testuser". Also "Offline_Link_Message" is not translated and set to "GO TO MESSAGE". System locale on Ubuntu 16.04 LTS:

LANG=de_DE.UTF-8
LANGUAGE=
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER="de_DE.UTF-8"
LC_NAME="de_DE.UTF-8"
LC_ADDRESS="de_DE.UTF-8"
LC_TELEPHONE="de_DE.UTF-8"
LC_MEASUREMENT="de_DE.UTF-8"
LC_IDENTIFICATION="de_DE.UTF-8"
LC_ALL=

see #4078

Should be something like this, but how do I get my current locale:

const message = TAPi18n.__('Offline_Link_Message', {}, 'de');
@localguru
Copy link
Contributor Author

Also the timezone of the Date: mail header is not correct, set to +0000 in case of CET

@hdralx
Copy link

hdralx commented Jul 19, 2017

same here.
a fix would be nice

@Ndrou
Copy link

Ndrou commented Jan 7, 2019

Same issue with 0.73.1. The emails are not localized.

@theorenck
Copy link
Contributor

@MarcosSpessatto can you take a look at this one and see if it's still a problem?

@pierre-lehnen-rc
Copy link
Contributor

Fixed by #13452

@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: i18n stat: triaged Issue reviewed and properly tagged type: improvement
Projects
None yet
Development

No branches or pull requests

8 participants