Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Preview broken for links with underlines #7482

Closed
id101010 opened this issue Jul 13, 2017 · 5 comments
Closed

Link Preview broken for links with underlines #7482

id101010 opened this issue Jul 13, 2017 · 5 comments
Milestone
0.58.0

Comments

@id101010
Copy link

Rocket.Chat Version: 0.54.0
Running Instances: ?
DB Replicaset OpLog: ?
Node Version: ?

The Link-Preview parser has trouble handling links that feature underlining such as wikipedia disambiguations.

Example:

The Link
https://en.wikipedia.org/wiki/Bear_(disambiguation)

produces a preview which directs to
https://en.wikipedia.org/wiki/Bear

The issue could be related to #6895
@localguru
Copy link
Contributor

localguru commented Jul 16, 2017 •
edited
Loading

Can confirm on 0.57.1

rc_lp

@localguru
Copy link
Contributor

I think it's duplicate of "Url in parsed in a wrong way" #7169

@localguru localguru mentioned this issue Jul 16, 2017
Closed
@id101010
Copy link
Author

@localguru Yes, this looks exactly like the same issue. Haven't found #7169 yet. :) Should we close this one?

image

@localguru
Copy link
Contributor

It's your issue. But yes, I would close it with a hint to #7169

@id101010
Copy link
Author

Closing issue. It is already covered by #7169.

@satyapramodh satyapramodh mentioned this issue Jul 21, 2017
Merged
@rodrigok rodrigok added this to the 0.58.0 milestone Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.58.0
Development

No branches or pull requests
3 participants
@rodrigok @id101010 @localguru