Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hide right side bar with click" setting breaks the flex tab #7756

Closed
JSzaszvari opened this issue Aug 16, 2017 · 8 comments
Closed

"Hide right side bar with click" setting breaks the flex tab #7756

JSzaszvari opened this issue Aug 16, 2017 · 8 comments

Comments

@JSzaszvari
Copy link
Contributor

Description:

After updating to 0.58.0 I am no longer to open the right sidebar in any browser, Clicking the icons do nothing. Am getting no errors in the browser console either.

image

Server Setup Information:

  • Version of Rocket.Chat Server: 0.58.0
  • Operating System: OS X and Widnows
  • Deployment Method(snap/docker/tar/etc): Docker
  • Number of Running Instances: 5
  • DB Replicaset Oplog: Yes

Steps to Reproduce:

  1. Click on anything in the sidebar

Expected behavior:

Sidebar should open.

Actual behavior:

Sidebar does not open.

Relevant logs:

Nothing coming up in console log in browser or server logs that would indicate a issue.

@JSzaszvari
Copy link
Contributor Author

Not working either in the Electron client.

@JSzaszvari
Copy link
Contributor Author

Tested on iOS and Android browser just now - Same issue

@JSzaszvari
Copy link
Contributor Author

I can confirm that rolling back to 0.57.3 has made the sidebar start working again. Just did it now.

@Gummikavalier
Copy link

Gummikavalier commented Aug 16, 2017

This happens on desktop browsers (Chrome, Firefox at least) too when personal profile option

Hide right side bar with click

is enabled.

This is with RC 0.58.0, in 0.57.3 it was still working.

@JSzaszvari
Copy link
Contributor Author

@Gummikavalier Good Find!

That indeed does make it start working again, Only issue is the rest of the users now. Might need to find a way to turn that off for everyone.

@Gummikavalier
Copy link

Gummikavalier commented Aug 16, 2017

@JSzaszvari I think it is off by default.

I had enabled it by myself in personal profile, so there might be an option in the Admin-settings if it's on in your setup by default.

Edit: Although now that I searched for such a global option I could not find it anywhere. Maybe it has never existed... However, off couple of other accounts I tested it was off in their personal settings too by default. Probably that's why it went unnoticed to release.

@geekgonecrazy
Copy link
Contributor

@rodrigok

@diegodorgam I know you saw this. Do you have the:

Hide right side bar with click
Option in your preferences?

@MartinSchoeler MartinSchoeler changed the title Unable to open the right sidebar menu "Hide right side bar with click" setting breaks the flex tab Aug 17, 2017
@Gummikavalier
Copy link

Works now in 0.58.1. Tested Chrome, Firefox and app. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants