Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis are not correctly replaced in longer messages #9351

Closed
vnkmpf opened this issue Jan 6, 2018 · 6 comments
Closed

Emojis are not correctly replaced in longer messages #9351

vnkmpf opened this issue Jan 6, 2018 · 6 comments

Comments

@vnkmpf
Copy link

vnkmpf commented Jan 6, 2018

Description:

Some ASCII emoticons in message are not correctly replaced with Emoji variant.
I do have enabled emojis in preferences.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.60.3
  • Operating System: Debian
  • Deployment Method(snap/docker/tar/etc): Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: -
  • Node Version: 8.9.3
  • Browsers: Firefox 57, Vivaldi, Palemoon, every browser I have tested

Steps to Reproduce:

  1. Type emojis especially in multi-line message (see included screenshots).

Expected behavior:

All emoticons are replaced with their emoji variant.

Actual behavior:

Certain emoticons aren't replaced.
To me it looks like mostly those followed with newline.

Relevant logs:

Screenshots

The first emoticon (line 1) isn't replaced (multiline message)
emojis_1

The last emoji (line 1) isn't replace (multiline message)
emojis_2

When using :slight_smile: everything works fine (line 1)
emojis_3

Multiple emoticons works, when sent in 2 messages (line 1 = msg 1, line 2 = msg 2)
emojis_4

The same sent as single message doesn't work for ending emoticons
emojis_5

@Otiel
Copy link

Otiel commented Feb 23, 2018

I think this is the same issue as #9498. Not exactly the same.

@karlprieb
Copy link
Contributor

Hey @vnkmpf thank you for your report! I tried here and you're right. We'll keep track of it, but it's not our priority to fix that right now.

@karlprieb karlprieb added this to the Mid-term milestone Feb 28, 2018
@vnkmpf
Copy link
Author

vnkmpf commented Feb 28, 2018

Sure, I knew broken emojis are not top priority :)
I was even wondering, if it can be some emoji library bug - not rocketchat's. But didn't give any research to it.

@gabriellsh
Copy link
Member

Tested 3.0.0-develop, Chrome Version 80.0.3987.87 (Official Build) (64-bit), macOS Catalina 10.15.2, works fine. If this still affects you, please reopen.

@gabriellsh
Copy link
Member

I just found out that this happens still, but only when using Marked parser.

@MartinSchoeler
Copy link
Contributor

Gazzodown should've fixed that, closing this, if it still happens on the latest version, please open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants