Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission for Delete Private Channels does not work #9927

Closed
arakon5 opened this issue Feb 27, 2018 · 1 comment · Fixed by #10438
Closed

Permission for Delete Private Channels does not work #9927

arakon5 opened this issue Feb 27, 2018 · 1 comment · Fixed by #10438

Comments

@arakon5
Copy link

arakon5 commented Feb 27, 2018

Description:

The permission "Delete Private Channels[delete-p]" seemed to be originally intended to allow private rooms to be deleted by their owners. Changing this no longer seems to have any effect, due to the template having "canDeleteRoom" button commented out completely (packages/rocketchat-channel-settings/client/views/channelSettings.html)

Possibly due to commit:
752bccd

Server Setup Information:

  • Version of Rocket.Chat Server: 0.61.0
  • Operating System: CentOS
  • Deployment Method(snap/docker/tar/etc): tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • Node Version: v8.9.3
  • mongoDB Version:

Steps to Reproduce:

  1. Set permissions so owners can delete private channels
  2. Create a private channel
  3. Go to Info, and no Delete button available.

Expected behavior:

A delete button to be available. This is important due to users needing to manage their own transient groups that will have limited lifespans and have no archive value.

Actual behavior:

No delete button is displayed.

Relevant logs:

@nemani
Copy link
Contributor

nemani commented Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants