[FIX] respect Accounts_Registration_Users_Default_Roles setting
#24173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
debdutdeb
changed the title
Accounts_Registration_Users_Default_Roles setting
|
We merge that and tested - it works perfect - new registered user gets only roles from list, and no |
|
Hope that PR will land to 4.4.0 release! |
matheusbsilva137
requested changes
Jan 27, 2022
* Create findOneByRolesAndType function and stop adding user role by default * Remove logs * Remove default user role in userHandler.js
debdutdeb
commented
Feb 11, 2022
ostjen
previously approved these changes
Feb 15, 2022
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
matheusbsilva137
previously approved these changes
Feb 15, 2022
… on server startup
matheusbsilva137
approved these changes
Feb 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Debdut Chakraborty debdut.chakraborty@rocket.chat
Proposed changes (including videos or screenshots)
userrole being added as default regardless of theAccounts_Registration_Users_Default_Rolessetting.Issue(s)
closes #24148
Steps to test or reproduce
admin;adminrole. The new account should not have theuserrole.