-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor button, add missing variants. #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: v0.2.0-alpha.20 feat: UiKit error states (#133) chore: Development mode (#127) fix plain text context (#132) feat: ui-kit initial value (#131) fix: ui-kit margins warnings and unique ids (#130) fix: Remove visibilty on transition (#129) fix: Modal's margins and AnimatedVisibility initial state (#128) fix: Modal background (#126) v0.2.0-alpha.19 fix: InputBox sizing (#124) fix: Position of inputs on selection buttons (#123) Create LICENSE (#122) feat: Position, Modal, Options components (#116)
…lage into feat/buttons * 'feat/buttons' of github.com:RocketChat/Rocket.Chat.Fuselage: update loki
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: v0.2.0-alpha.25 fix: Select autofocus (#141) v0.2.0-alpha.24 chore: configure react as peerDependencies (#140) chore: Fuselage: select states (error/disabled) (#139) v0.2.0-alpha.23 fix: Section with Overflow visibility (#138) fix overflow v0.2.0-alpha.22 fix: UIKit stopPropagation (#137)
…lage into feat/buttons * 'feat/buttons' of github.com:RocketChat/Rocket.Chat.Fuselage: update loki
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: (26 commits) v0.4.0 feat!: CSS-in-JS for modifiers of Box (#164) perf: Avoid re-renders due to PropsContext (#154) feat: useMutableCallback (#156) chore: Add bug report template (#158) feat: Added callback prop for scroll position (#155) fix: Display name and prop types of Throbber component (#148) fix: Changed accordion item title proptype (#151) v0.3.0 fix: actionId on action hooks (#149) v0.2.0 (#150) chore: Tabs Layout (#125) feat: Loading Component (#147) v0.2.0 v0.2.0-alpha.30 fix: Safari not triggering buttons anchors (#146) v0.2.0-alpha.29 bump version (#145) v0.2.0-alpha.28 fix: placeholder transition (#144) ...
gabriellsh
force-pushed
the
feat/buttons
branch
from
March 11, 2020 16:30
519ed69
to
2a9c8bc
Compare
gabriellsh
force-pushed
the
feat/buttons
branch
from
March 11, 2020 17:20
a4b051e
to
2a9c8bc
Compare
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: v0.5.0 feat: Tags and Badges (#167) fix: Empty space before SelectFiltered placeholder (#171) feat: Focus visible (#165) feat: Tooltip component (#121) v0.4.1 fix: filteredOptions for options (#169) chore: fixed grammer in README (#168) fix: Select arrow position for empty selects (#157) fix: Build @rocket.chat/css-in-js as ES module (#166) chore: Added x48 avatar size (#170)
…lage into feat/buttons * 'feat/buttons' of github.com:RocketChat/Rocket.Chat.Fuselage:
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: v0.6.0 feat: add stack avatar (#174)
gabriellsh
changed the title
fix: Buttons missing styles
chore: Refactor button, add missing variants.
Mar 23, 2020
ggazzo
approved these changes
Mar 23, 2020
ggazzo
added a commit
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing styles to the buttons, changing variation style from prop to multiple components.