feat: Sidebar Item #284
Merged
feat: Sidebar Item #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| display: flex; | ||
| align-items: center; | ||
| border-radius: lengths.border-radius(2); | ||
| @include typography.use-font-scale(p1); |
There was a problem hiding this comment.
Please check validity of the block starting from line #18
| @@ -28,3 +28,4 @@ | |||
| @import './Tile/styles.scss'; | |||
| @import './ToggleSwitch/styles.scss'; | |||
| @import './Tooltip/styles.scss'; | |||
| @import './SideBar/styles.scss'; | |||
There was a problem hiding this comment.
File extensions are not allowed
ggazzo
force-pushed
the
sidebar
branch
6 times, most recently
from
67d2a37
to
b7b6f76
Compare
| @@ -52,6 +52,10 @@ | |||
| .rcx-button-group.rcx-button-group--small > & { | |||
| margin-inline: lengths.margin(2); | |||
| } | |||
|
|
|||
| .rcx-button-group.rcx-button-group--medium > & { | |||
There was a problem hiding this comment.
Class should be nested within its parent Class
| @@ -52,6 +52,10 @@ | |||
| .rcx-button-group.rcx-button-group--small > & { | |||
| margin-inline: lengths.margin(2); | |||
| } | |||
|
|
|||
| .rcx-button-group.rcx-button-group--medium > & { | |||
There was a problem hiding this comment.
Space expected between blocks
|
SourceLevel has finished reviewing this Pull Request and has found:
|
gabriellsh
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.