Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set a conservative output.environment on Webpack bundles #330

Merged
merged 1 commit into from
Nov 14, 2020
Merged

fix: Set a conservative output.environment on Webpack bundles #330

merged 1 commit into from
Nov 14, 2020

Conversation

tassoevan
Copy link
Collaborator

It should get rid of ES2015 syntax on Webpack support code in bundles.

@tassoevan tassoevan requested a review from a team November 13, 2020 04:49
MartinSchoeler
MartinSchoeler approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this fixes the problems with IE and it doesn't seem to disrupt older versions of RC as well (3.7.x)

@ggazzo ggazzo merged commit 62bf728 into develop Nov 14, 2020
@ggazzo ggazzo deleted the fix/webpack-bundles branch November 14, 2020 01:16
ggazzo pushed a commit that referenced this pull request Nov 16, 2020
@tassoevan @ggazzo
fix: Set a conservative output.environment on Webpack bundles (#330)
85d4a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees
No one assigned
Labels
📦 fuselage 📦 fuselage-ui-kit 📦 ui-kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tassoevan @MartinSchoeler @ggazzo