Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onboarding-ui): Common components #478

Merged
merged 21 commits into from
Jun 30, 2021
Merged

feat(onboarding-ui): Common components #478

merged 21 commits into from
Jun 30, 2021

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Jun 21, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@tassoevan tassoevan force-pushed the feat/onboarding/common-components branch 4 times, most recently from 7c4e2f0 to 34bf680 Compare June 25, 2021 21:52
@tassoevan tassoevan added the 📦 onboarding-ui @rocket.chat/onboarding-ui label Jun 26, 2021
@tassoevan tassoevan changed the title feat/onboarding/common-components feat(onboarding-ui): Common components Jun 26, 2021
@tassoevan tassoevan requested a review from a team June 27, 2021 18:57
@tassoevan tassoevan marked this pull request as ready for review June 27, 2021 18:57
@RocketChat RocketChat deleted a comment from lgtm-com bot Jun 29, 2021
@ggazzo ggazzo merged commit d7511ab into develop Jun 30, 2021
@ggazzo ggazzo deleted the feat/onboarding/common-components branch June 30, 2021 13:51
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
📦 onboarding-ui @rocket.chat/onboarding-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo