Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onboarding-ui): CloudOrganizationInfo Page #498

Merged
merged 9 commits into from
Aug 18, 2021
Merged

feat(onboarding-ui): CloudOrganizationInfo Page #498

merged 9 commits into from
Aug 18, 2021

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 14, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@dougfabris dougfabris added the 📦 onboarding-ui @rocket.chat/onboarding-ui label Jul 14, 2021
@dougfabris dougfabris changed the title new: CloudOrganizationInfo Page feat(onboarding-ui): CloudOrganizationInfo Page Jul 22, 2021
tassoevan
tassoevan requested changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not right with the "Next" button when there is option to skip the wizard step.

@dougfabris dougfabris closed this Jul 26, 2021
@dougfabris dougfabris reopened this Jul 26, 2021
@dougfabris
Copy link
Member Author

Something is not right with the "Next" button when there is option to skip the wizard step.

Solved!

@tassoevan tassoevan merged commit 4d04e66 into develop Aug 18, 2021
@tassoevan tassoevan deleted the new/cloud-orgInfo-page branch August 18, 2021 16:42
This was referenced Sep 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
📦 onboarding-ui @rocket.chat/onboarding-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougfabris @tassoevan