Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onboarding-ui): RegisterServer Step Flow #618

Merged
merged 9 commits into from
Jan 18, 2022
Merged

feat(onboarding-ui): RegisterServer Step Flow #618

merged 9 commits into from
Jan 18, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 17, 2022 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@dougfabris dougfabris added the 📦 onboarding-ui @rocket.chat/onboarding-ui label Jan 17, 2022
@dougfabris dougfabris requested a review from a team January 17, 2022 18:52
@ghost
Copy link

ghost commented Jan 17, 2022 •
edited by ghost
Loading

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

tassoevan
tassoevan previously approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex-shrink: 0; does the trick for positioning BackgroundLayer in viewport, as the root elements in Rocket.Chat and at cloud client are styled with display: flex;.

@tassoevan tassoevan changed the title [IMPROVE] RegisterServer Step Flow feat(onboarding-ui): RegisterServer Step Flow Jan 18, 2022
@tassoevan tassoevan merged commit f8098eb into develop Jan 18, 2022
@tassoevan tassoevan deleted the improve/registerServer branch January 18, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
📦 onboarding-ui @rocket.chat/onboarding-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougfabris @tassoevan