Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(memo): Cache timeout #630

Merged
merged 8 commits into from
Feb 14, 2022
Merged

feat(memo): Cache timeout #630

merged 8 commits into from
Feb 14, 2022

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Jan 27, 2022 •
edited by guijun13
Loading

Proposed changes (including videos or screenshots)

  • Add optional parameter maxAge that adds a timeout functionality for memoize function.
  • Add unit tests for timed and not timed memoize functions usages.

Issue(s)

Fixes #517

Further comments

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@guijun13 guijun13 marked this pull request as ready for review February 11, 2022 17:13
dougfabris
dougfabris requested changes Feb 14, 2022
View reviewed changes
packages/memo/src/memoize.ts Outdated Show resolved Hide resolved
@tassoevan tassoevan merged commit 9e36aec into develop Feb 14, 2022
@tassoevan tassoevan deleted the feat/memo-cache-timeout branch February 14, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guijun13 guijun13 guijun13 left review comments

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memoize expire timeout
4 participants
@tassoevan @CLAassistant @dougfabris @guijun13