Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding-ui): allow title and subtitle editing #665

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

PedroRorato
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Changed title and subtitle to variables to allow reusing the page component.
    *I've kept the old texts as default values to the variables to keep supporting

Screen Shot 2022-03-16 at 17 34 37

@PedroRorato PedroRorato marked this pull request as ready for review March 16, 2022 21:01
@PedroRorato PedroRorato requested a review from a team March 17, 2022 17:19
@PedroRorato PedroRorato merged commit fc7974e into develop Mar 21, 2022
@PedroRorato PedroRorato deleted the feat-update-check-your-email-page branch March 21, 2022 19:00
@dougfabris dougfabris added the 📦 onboarding-ui @rocket.chat/onboarding-ui label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 onboarding-ui @rocket.chat/onboarding-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants