Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-parser): Link is not showing correct and it not opening correctly #717

Merged
merged 2 commits into from
May 11, 2022

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented May 10, 2022

closes #713

Proposed changes (including videos or screenshots)

Update message-parser link file and tests to fit links with hash and complementing URL Path after URL Hash

Solution: Add additional urlPath to URL grammar

Output:
image

Issue(s)

Link is not showing correct and it not opening correctly.
Steps to reproduce:

  1. Log in to the rocket.chat
  2. Click on Avatar/My account/preferences/global/Enable New Message Template and enable the option
  3. Open some existent room/create a new room
  4. Send the link : https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351

Actual result:
The link was displayed with some black parts:
image

Note: when you click on the link just the blue part opened:

[Test](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351) 

Expected result:
The link should be displayed in blue, and should be opened the entire link when you click on the link:

Further comments

Solution developed to fit these test cases:

https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351

<https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351|Rocket.Chat Link Test>

[Rocket.Chat Link Test](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)

[**Rocket.Chat Link Test**](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)

[~~Rocket.Chat Link Test~~](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)

[__Rocket.Chat Link Test__](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)

[__**~~Rocket.Chat Link Test~~**__](https://desk.rocket.chat/support/rocketchat/ShowHomePage.do#Cases/dv/413244000073043351)

@CLAassistant
Copy link

CLAassistant commented May 10, 2022

CLA assistant check
All committers have signed the CLA.

@hugocostadev hugocostadev requested a review from ggazzo May 10, 2022 16:36
@ggazzo ggazzo merged commit 886d2c0 into develop May 11, 2022
@ggazzo ggazzo deleted the fix/message-parser-link branch May 11, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message-parser: Url
3 participants